tests: Use "bash strict mode"

I noticed in the static deltas tests, there were some tests that
should have been under `-o pipefail` to ensure we properly propagate
errors.

There were a few places where we were referencing undefined variables.

Overall, this is clearly a good idea IMO.

diff --git a/tests/admin-test.sh b/tests/admin-test.sh
index edbf66513e1d2a67e7d2032396752f266c688a29..a587d79b20dc717190d07c5c47fc2def5cec6733 100755 (executable)
--- a/tests/admin-test.sh
+++ b/tests/admin-test.sh
@@ -16,7 +16,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 echo "1..10"
 

diff --git a/tests/archive-test.sh b/tests/archive-test.sh
index 9d9c0a2837cb1d638f9ddb52fa66d1c240869f5d..e6f67cf5c03272485211532cbb4479c990a33528 100755 (executable)
--- a/tests/archive-test.sh
+++ b/tests/archive-test.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 $OSTREE checkout test2 checkout-test2
 echo "ok checkout"

diff --git a/tests/basic-test.sh b/tests/basic-test.sh
index e8f1e9d2c5b22e97c16921c8ace0d7facab7ecd3..d39f32cfa3b8f4fce4da817201c695886dda137d 100755 (executable)
--- a/tests/basic-test.sh
+++ b/tests/basic-test.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 echo "1..48"
 

diff --git a/tests/libtest.sh b/tests/libtest.sh
index 885c64038cc33c37c6d9e0cb9c833a076c8557b4..bd806f6df566b4b8c9e90105dda9e73387f1d0de 100644 (file)
--- a/tests/libtest.sh
+++ b/tests/libtest.sh
@@ -33,11 +33,11 @@ cp -a ${SRCDIR}/gpghome ${test_tmpdir}
 export TEST_GPG_KEYHOME=${test_tmpdir}/gpghome
 export OSTREE_GPG_HOME=${test_tmpdir}/gpghome/trusted
 
-if test -n "${OT_TESTS_DEBUG}"; then
+if test -n "${OT_TESTS_DEBUG:-}"; then
     set -x
 fi
 
-if test -n "$OT_TESTS_VALGRIND"; then
+if test -n "${OT_TESTS_VALGRIND:-}"; then
     CMD_PREFIX="env G_SLICE=always-malloc valgrind -q --leak-check=full --num-callers=30 --suppressions=${SRCDIR}/ostree-valgrind.supp"
 else
     CMD_PREFIX="env LD_PRELOAD=${SRCDIR}/libreaddir-rand.so"
@@ -139,8 +139,8 @@ setup_test_repository () {
 
 setup_fake_remote_repo1() {
     mode=$1
-    commit_opts=$2
-    args=$3
+    commit_opts=${2:-}
+    args=${3:-}
     shift
     oldpwd=`pwd`
     mkdir ostree-srv
@@ -272,7 +272,7 @@ EOF
     mkdir ${test_tmpdir}/httpd
     cd httpd
     ln -s ${test_tmpdir} ostree
-    ${CMD_PREFIX} ostree trivial-httpd --autoexit --daemonize -p ${test_tmpdir}/httpd-port $args
+    ${CMD_PREFIX} ostree trivial-httpd --autoexit --daemonize -p ${test_tmpdir}/httpd-port
     port=$(cat ${test_tmpdir}/httpd-port)
     echo "http://127.0.0.1:${port}" > ${test_tmpdir}/httpd-address
     cd ${oldpwd} 
@@ -280,15 +280,9 @@ EOF
 
 os_repository_new_commit ()
 {
-    boot_checksum_iteration=$1
-    content_iteration=$2
+    boot_checksum_iteration=${1:-0}
+    content_iteration=${2:-0}
     echo "BOOT ITERATION: $boot_checksum_iteration"
-    if test -z "$boot_checksum_iteration"; then
-       boot_checksum_iteration=0
-    fi
-    if test -z "$content_iteration"; then
-       content_iteration=0
-    fi
     cd ${test_tmpdir}/osdata
     rm boot/*
     echo "new: a kernel ${boot_checksum_iteration}" > boot/vmlinuz-3.6.0

diff --git a/tests/pull-test.sh b/tests/pull-test.sh
index 42979fe97956befd183ae25fe879a05d5d0314c0..6f0b651af9da98b9b47253815ef9bec2224a555b 100755 (executable)
--- a/tests/pull-test.sh
+++ b/tests/pull-test.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 function repo_init() {
     cd ${test_tmpdir}

diff --git a/tests/test-admin-deploy-2.sh b/tests/test-admin-deploy-2.sh
index d6117de06e8e06fdfc4995a586e4e64359c30b3f..ef6b59530a31cf86d46e0c4a5906b84a587e63a8 100755 (executable)
--- a/tests/test-admin-deploy-2.sh
+++ b/tests/test-admin-deploy-2.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 . $(dirname $0)/libtest.sh
 
@@ -49,7 +49,6 @@ os_repository_new_commit "1"
 bootcsum3=${bootcsum}
 ${CMD_PREFIX} ostree admin upgrade --os=testos
 
-rev=${newrev}
 newrev=$(${CMD_PREFIX} ostree --repo=sysroot/ostree/repo rev-parse testos/buildmaster/x86_64-runtime)
 assert_not_streq ${rev} ${newrev}
 assert_not_streq ${bootcsum1} ${bootcsum2}

diff --git a/tests/test-admin-deploy-clean.sh b/tests/test-admin-deploy-clean.sh
index 19f71e6112914d3a053ed6c81343fa87715c09db..582831086d825650f5f586b548e1dc29d44ac5b4 100644 (file)
--- a/tests/test-admin-deploy-clean.sh
+++ b/tests/test-admin-deploy-clean.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 . $(dirname $0)/libtest.sh
 

diff --git a/tests/test-admin-deploy-etcmerge-cornercases.sh b/tests/test-admin-deploy-etcmerge-cornercases.sh
index 0541a670d7d8dee2001914aee59e186b28f2aaea..4b0d781b916a935b1af66b48b1b098b7300409c9 100644 (file)
--- a/tests/test-admin-deploy-etcmerge-cornercases.sh
+++ b/tests/test-admin-deploy-etcmerge-cornercases.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 . $(dirname $0)/libtest.sh
 

diff --git a/tests/test-admin-deploy-grub2.sh b/tests/test-admin-deploy-grub2.sh
index 94c4bc03da71279a4992163ce865ce5213253110..8da294d76a8829064ee7d28bcd6fe78d9ada765f 100755 (executable)
--- a/tests/test-admin-deploy-grub2.sh
+++ b/tests/test-admin-deploy-grub2.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 . $(dirname $0)/libtest.sh
 

diff --git a/tests/test-admin-deploy-karg.sh b/tests/test-admin-deploy-karg.sh
index 9decec67e47c937401efb04ba70e323ae55bbb8b..a8c1e594791a2b80a325744c77fe4212b20dd0c5 100644 (file)
--- a/tests/test-admin-deploy-karg.sh
+++ b/tests/test-admin-deploy-karg.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 . $(dirname $0)/libtest.sh
 

diff --git a/tests/test-admin-deploy-switch.sh b/tests/test-admin-deploy-switch.sh
index 7e1e173aa86361dcfae7969356b0c26fbcace0f3..4a52000c490d54a097420729fe93d85234081160 100755 (executable)
--- a/tests/test-admin-deploy-switch.sh
+++ b/tests/test-admin-deploy-switch.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 . $(dirname $0)/libtest.sh
 

diff --git a/tests/test-admin-deploy-syslinux.sh b/tests/test-admin-deploy-syslinux.sh
index 97ee32df190ead6a0c3f09ecae5a00ac86015866..5883f76d46310b2f21b2c3b1e847161ff790c7b0 100755 (executable)
--- a/tests/test-admin-deploy-syslinux.sh
+++ b/tests/test-admin-deploy-syslinux.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 . $(dirname $0)/libtest.sh
 

diff --git a/tests/test-admin-deploy-uboot.sh b/tests/test-admin-deploy-uboot.sh
index 219db14b547dd743b3a0dafd5eb24a2ac422bc48..c22af6f3e661627cd61e22cdb1f6706099b6763f 100755 (executable)
--- a/tests/test-admin-deploy-uboot.sh
+++ b/tests/test-admin-deploy-uboot.sh
@@ -18,7 +18,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 . $(dirname $0)/libtest.sh
 

diff --git a/tests/test-admin-instutil-set-kargs.sh b/tests/test-admin-instutil-set-kargs.sh
index 04f98c011ebffe80dc0339f7aa955c41d5ec1350..33b2b74e1bd31807e0fce395baccd9986789908e 100644 (file)
--- a/tests/test-admin-instutil-set-kargs.sh
+++ b/tests/test-admin-instutil-set-kargs.sh
@@ -18,7 +18,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 . $(dirname $0)/libtest.sh
 

diff --git a/tests/test-admin-locking.sh b/tests/test-admin-locking.sh
index 6b4322029a85c819b7e57746a5dbdbc8377e1ef4..5f00f57104a1ba077e5557e2c89993fb6dfbea48 100644 (file)
--- a/tests/test-admin-locking.sh
+++ b/tests/test-admin-locking.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 . $(dirname $0)/libtest.sh
 

diff --git a/tests/test-admin-pull-deploy-commit.sh b/tests/test-admin-pull-deploy-commit.sh
index 08c1e6bdc8b0f1bbca7a017e0e46170efa8f5da2..e1f7def6881cd8903f0bb99f425c3e7d050ff069 100644 (file)
--- a/tests/test-admin-pull-deploy-commit.sh
+++ b/tests/test-admin-pull-deploy-commit.sh
@@ -19,7 +19,7 @@
 
 # See https://github.com/GNOME/ostree/pull/145
 
-set -e
+set -euo pipefail
 
 . $(dirname $0)/libtest.sh
 

diff --git a/tests/test-admin-upgrade-not-backwards.sh b/tests/test-admin-upgrade-not-backwards.sh
index c42dc242ef07af792a9e92d658a7229cfa558703..1b99e25d64f124ba6e734dd5daacc469ed212254 100644 (file)
--- a/tests/test-admin-upgrade-not-backwards.sh
+++ b/tests/test-admin-upgrade-not-backwards.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 . $(dirname $0)/libtest.sh
 

diff --git a/tests/test-admin-upgrade-unconfigured.sh b/tests/test-admin-upgrade-unconfigured.sh
index cbc1e753d2c3c873d0e33d53a37625a7165ec639..38df710db83d5cfb694bec3f4d0acb56b4a8c1b8 100644 (file)
--- a/tests/test-admin-upgrade-unconfigured.sh
+++ b/tests/test-admin-upgrade-unconfigured.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 . $(dirname $0)/libtest.sh
 

diff --git a/tests/test-archivez.sh b/tests/test-archivez.sh
index d5b7fc357a2907bcebb9e2092a1e732ba5318d79..5db973ffb8bda4e0524bc6b36411c5878dbaf255 100755 (executable)
--- a/tests/test-archivez.sh
+++ b/tests/test-archivez.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 . $(dirname $0)/libtest.sh
 

diff --git a/tests/test-auto-summary.sh b/tests/test-auto-summary.sh
index 2452e553ae0767e9cecab6c6956fe638439e6570..6cb52e8ceedb73c4dce5eea9419deeb1f95cea17 100755 (executable)
--- a/tests/test-auto-summary.sh
+++ b/tests/test-auto-summary.sh
@@ -18,7 +18,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 echo "1..1"
 

diff --git a/tests/test-basic-user.sh b/tests/test-basic-user.sh
index c1705254bf77eb6ca189d42d302ef19175dca4eb..f53de89a7adc1e8994b529e3ed227db1079ad457 100755 (executable)
--- a/tests/test-basic-user.sh
+++ b/tests/test-basic-user.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 echo "1..1"
 

diff --git a/tests/test-basic.sh b/tests/test-basic.sh
index 3c55756e6af1adb038a69675a56783de133b3359..ae55aab272df4e238a7245fa2300c3f0c023f6b7 100755 (executable)
--- a/tests/test-basic.sh
+++ b/tests/test-basic.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 echo "1..1"
 

diff --git a/tests/test-commit-sign.sh b/tests/test-commit-sign.sh
index 0dfbb768d78a1d6716211a4c6604298c6989e084..2db671eeb38f01e853a65ade0e2b36f3b77e1526 100755 (executable)
--- a/tests/test-commit-sign.sh
+++ b/tests/test-commit-sign.sh
@@ -17,9 +17,9 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
-if ! ${CMD_PREFIX} ostree --version | grep -q -e '\+gpgme'; then
+if ! ostree --version | grep -q -e '\+gpgme'; then
     exit 77
 fi
 

diff --git a/tests/test-corruption.sh b/tests/test-corruption.sh
index 9ad6aaf233e020b187896a2d693d5e57bd7c45d8..ef0e94ef1c8274f8afbf8de771af0cf257b0b50b 100755 (executable)
--- a/tests/test-corruption.sh
+++ b/tests/test-corruption.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 echo "1..2"
 

diff --git a/tests/test-delta.sh b/tests/test-delta.sh
index 2dddefee64ab7fab09f7085470657f29838d2b68..b31d65e9d65dbf5f00094099e6ded27aa56344c5 100755 (executable)
--- a/tests/test-delta.sh
+++ b/tests/test-delta.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 . $(dirname $0)/libtest.sh
 

diff --git a/tests/test-gpg-signed-commit.sh b/tests/test-gpg-signed-commit.sh
index ba361c7a04588ae0f6763c0dcd058d00a699fd43..b713da2db3210c0cd51deaed7a5b4d74661264db 100644 (file)
--- a/tests/test-gpg-signed-commit.sh
+++ b/tests/test-gpg-signed-commit.sh
@@ -18,9 +18,9 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
-if ! ${CMD_PREFIX} ostree --version | grep -q -e '\+gpgme'; then
+if ! ostree --version | grep -q -e '\+gpgme'; then
     exit 77
 fi
 

diff --git a/tests/test-help.sh b/tests/test-help.sh
index 37d9fa1df95334f3af6e679eaf224d3545df1e89..ca555b1b1c75126acd11180f08353581254567a3 100755 (executable)
--- a/tests/test-help.sh
+++ b/tests/test-help.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 . $(dirname $0)/libtest.sh
 
@@ -45,7 +45,7 @@ test_recursive() {
         if [ $? = 0 ] ; then
            echo 1>&2 "missing subcommand but 0 exit status"; exit 1
         fi
-        set -e
+        set -euo pipefail
         # error message and usage goes to standard error
         assert_file_has_content err "[Uu]sage"
         assert_file_has_content err "$cmd"

diff --git a/tests/test-libarchive.sh b/tests/test-libarchive.sh
index c875f6b014d7035ce31d90b2c7d5059a3bf83849..92e2408370c30229c4f29d312b8547d976171c05 100755 (executable)
--- a/tests/test-libarchive.sh
+++ b/tests/test-libarchive.sh
@@ -17,9 +17,9 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
-if ! ${CMD_PREFIX} ostree --version | grep -q -e '\+libarchive'; then
+if ! ostree --version | grep -q -e '\+libarchive'; then
     exit 77
 fi
 

diff --git a/tests/test-local-pull-depth.sh b/tests/test-local-pull-depth.sh
index 4f8988dcf2250f826c1d868c43abee7945b3d4b2..e89d09140e2308593fa3463e8ec677104ead6d3d 100755 (executable)
--- a/tests/test-local-pull-depth.sh
+++ b/tests/test-local-pull-depth.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 . $(dirname $0)/libtest.sh
 

diff --git a/tests/test-local-pull.sh b/tests/test-local-pull.sh
index df5342ded4c006853cdcd816e3bc8ad6c95bbfc8..a9beb08388e3f1d2d2a6e75b1ee139609ef58418 100755 (executable)
--- a/tests/test-local-pull.sh
+++ b/tests/test-local-pull.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 echo "1..1"
 

diff --git a/tests/test-oldstyle-partial.sh b/tests/test-oldstyle-partial.sh
index b7da9a86d2cc92c19b0b040a3ad220b62c5da98c..220b0831ce36bfabb737a08aab00370d04caed76 100644 (file)
--- a/tests/test-oldstyle-partial.sh
+++ b/tests/test-oldstyle-partial.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 . $(dirname $0)/libtest.sh
 

diff --git a/tests/test-prune.sh b/tests/test-prune.sh
index 28695b8f84edfca2ebe47b51068c6025d931c083..a1322d90f1727a7aec9e3d7ac0ba7e5b13dbba4e 100644 (file)
--- a/tests/test-prune.sh
+++ b/tests/test-prune.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 . $(dirname $0)/libtest.sh
 

diff --git a/tests/test-pull-archive-z.sh b/tests/test-pull-archive-z.sh
index 0d2085285c71817e77ef40c68797c393aaae7f33..6482f6f91f1e53fb2753aa0f6d3e9f7bbd620212 100755 (executable)
--- a/tests/test-pull-archive-z.sh
+++ b/tests/test-pull-archive-z.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 . $(dirname $0)/libtest.sh
 

diff --git a/tests/test-pull-commit-only.sh b/tests/test-pull-commit-only.sh
index 136cc3b9befdf0571032bb6d94cdff0c05555d45..775b2f7198208ee138ba02087e2db121541a08a9 100755 (executable)
--- a/tests/test-pull-commit-only.sh
+++ b/tests/test-pull-commit-only.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 . $(dirname $0)/libtest.sh
 

diff --git a/tests/test-pull-corruption.sh b/tests/test-pull-corruption.sh
index e81e422969c7b47a5d8fe6a36e1ca95bb9cf7fa7..1df31943d43d2b68b348d9084388fa180c4418be 100755 (executable)
--- a/tests/test-pull-corruption.sh
+++ b/tests/test-pull-corruption.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 . $(dirname $0)/libtest.sh
 
@@ -55,4 +55,4 @@ gjs --help >/dev/null 2>&1 || exit 77
 gjs $(dirname $0)/corrupt-repo-ref.js ${repopath} main || true
 assert_file_has_content corrupted-status.txt 'Changed byte'
 do_corrupt_pull_test
-echo "ok corruption $iteration"
+echo "ok corruption"

diff --git a/tests/test-pull-depth.sh b/tests/test-pull-depth.sh
index 35191cc41dbeed6a8ad25ad6a13539ad8394b4b4..7a52f9cbcb7a87398703fb5d15496d9f4e311d94 100644 (file)
--- a/tests/test-pull-depth.sh
+++ b/tests/test-pull-depth.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 . $(dirname $0)/libtest.sh
 

diff --git a/tests/test-pull-large-metadata.sh b/tests/test-pull-large-metadata.sh
index f86ce4be00102dab4874de9bb4bb6de9b285e349..c50d79430ba2148d01511a9feb2a1e65c5912b97 100644 (file)
--- a/tests/test-pull-large-metadata.sh
+++ b/tests/test-pull-large-metadata.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 . $(dirname $0)/libtest.sh
 

diff --git a/tests/test-pull-metalink.sh b/tests/test-pull-metalink.sh
index 84ef3739e8c88475a0cf4b5676e2843fa0c592fb..52d2d503d23062972985ebcd09e66bb19949bfa5 100755 (executable)
--- a/tests/test-pull-metalink.sh
+++ b/tests/test-pull-metalink.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 . $(dirname $0)/libtest.sh
 

diff --git a/tests/test-pull-mirror-summary.sh b/tests/test-pull-mirror-summary.sh
index 958044f9a74f15bbe8b5e4c8594364e73c9edc94..de55b59b909c341a5e2e25bec4bcf5dc0cbbdd32 100755 (executable)
--- a/tests/test-pull-mirror-summary.sh
+++ b/tests/test-pull-mirror-summary.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 . $(dirname $0)/libtest.sh
 

diff --git a/tests/test-pull-resume.sh b/tests/test-pull-resume.sh
index 25ee907e1beb02cd3471da909b1c336824a89d39..1e7220d09c74fc74f6cf0b9430ca15f11078fa42 100755 (executable)
--- a/tests/test-pull-resume.sh
+++ b/tests/test-pull-resume.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 . $(dirname $0)/libtest.sh
 

diff --git a/tests/test-pull-subpath.sh b/tests/test-pull-subpath.sh
index f2abbb3bbdd594be567cbb807b192a78c1ca87d6..7034832237c2a02f3dad424dfcbf1a89f456b71b 100644 (file)
--- a/tests/test-pull-subpath.sh
+++ b/tests/test-pull-subpath.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 . $(dirname $0)/libtest.sh
 

diff --git a/tests/test-pull-summary-sigs.sh b/tests/test-pull-summary-sigs.sh
index 7afca9a36744f5fa8b797097db552151204e6c22..dbcc67a54e469b7febb9ec16315932929e4c54b9 100644 (file)
--- a/tests/test-pull-summary-sigs.sh
+++ b/tests/test-pull-summary-sigs.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 . $(dirname $0)/libtest.sh
 

diff --git a/tests/test-remote-add.sh b/tests/test-remote-add.sh
index 392dda54ebee9d4f04fc49f4221c902680146afa..2294a06da55293b5cc90abc884270a7a86d1ce5e 100755 (executable)
--- a/tests/test-remote-add.sh
+++ b/tests/test-remote-add.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 . $(dirname $0)/libtest.sh
 

diff --git a/tests/test-remote-gpg-import.sh b/tests/test-remote-gpg-import.sh
index 0dc5424e4eece430012d9cd1df6f8c457be481ef..fc833493537b8160493b8fb90b110c9cf61e864d 100755 (executable)
--- a/tests/test-remote-gpg-import.sh
+++ b/tests/test-remote-gpg-import.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 . $(dirname $0)/libtest.sh
 

diff --git a/tests/test-repo-checkout-subpath.sh b/tests/test-repo-checkout-subpath.sh
index 343b26141384654b067c82f00c90d96cdc2bfd4f..bf792184493e9aec545e9c20a71184e2f6f325ee 100755 (executable)
--- a/tests/test-repo-checkout-subpath.sh
+++ b/tests/test-repo-checkout-subpath.sh
@@ -18,7 +18,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 . $(dirname $0)/libtest.sh
 

diff --git a/tests/test-reset-nonlinear.sh b/tests/test-reset-nonlinear.sh
index 1d0f8de600aecc6d49d01c6b30da870d4601e525..735f15231c8285645695eca265da764e2b91cc45 100755 (executable)
--- a/tests/test-reset-nonlinear.sh
+++ b/tests/test-reset-nonlinear.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 echo "1..1"
 

diff --git a/tests/test-setuid.sh b/tests/test-setuid.sh
index 02aa9f61606ec438626993c0e4575881fd97f8ef..5354d1f3b1073a61763abdc88f483d2e4e655e30 100755 (executable)
--- a/tests/test-setuid.sh
+++ b/tests/test-setuid.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 echo "1..1"
 

diff --git a/tests/test-xattrs.sh b/tests/test-xattrs.sh
index b95707e266891fe77871f7612eb8369fb8bc42b6..6a83a0bcebd78a9c6301c8e8cd83966331fb0a32 100755 (executable)
--- a/tests/test-xattrs.sh
+++ b/tests/test-xattrs.sh
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 # Boston, MA 02111-1307, USA.
 
-set -e
+set -euo pipefail
 
 touch test-xattrs
 if ! setfattr -n user.testvalue -v somevalue test-xattrs; then